Repository navigation
fix(locales): normalize apostrophe forms - #697
Merged
Merged
Conversation
Use typographic apostrophes in English names and transliteration characters for Arabic and Hebrew.
Owner
|
Typesetting is about pleasing the eye. Nothing against beauty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While comparing holiday data in opening_hours.js and date-holidays, I noticed inconsistent apostrophe usage in English names.
Curly apostrophes were already used in some names here, while others still used straight apostrophes. This change makes the existing typography consistent across the data.
Straight apostrophes are common and understandable, including in official sources, but the curly apostrophe is the typographically correct glyph in polished text. Where an apostrophe-like mark represented a transliteration character, I used the appropriate Arabic or Hebrew character instead.
This is a fairly large nitpick PR, but I hope you are open to it 🙂